Skip to content

Plugin e2e: support node 24 and drop support for node 18 #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Plugin e2e: support node 24 and drop support for node 18 #2242

merged 1 commit into from
Oct 28, 2025
+1 −1

Conversation

@jackw
Copy link
Collaborator

@jackw jackw commented Oct 24, 2025 •
edited
Loading

What this PR does / why we need it:

Node LTS has moved to Node 24 . This PR updates plugin-e2e's engines to drop support for Node 18 and include support for Node 24.

Marking it as a major breaking change given we're dropping support for node 18, which is end of life.

Which issue(s) this PR fixes:

Fixes #2107

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install [email protected]
npm install @grafana/[email protected]
# or 
yarn add [email protected]
yarn add @grafana/[email protected]

@jackw jackw self-assigned this Oct 24, 2025
Copilot AI review requested due to automatic review settings October 24, 2025 09:00
@jackw jackw requested a review from a team as a code owner October 24, 2025 09:00
@jackw jackw added the major Increment the major version when merged label Oct 24, 2025
@jackw jackw requested a review from a team as a code owner October 24, 2025 09:00
@jackw jackw added the release Create a release when this pr is merged label Oct 24, 2025
@jackw jackw requested a review from sunker October 24, 2025 09:00
@jackw jackw added the plugin-e2e related to the plugin-e2e package label Oct 24, 2025
Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Node.js version requirements for the plugin-e2e package to align with current LTS support, dropping Node 18 (which has reached end of life) and adding support for Node 24.

Key Changes:

  • Updated the engines.node field to require Node 20 or higher (up to Node 24)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new major release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Oct 24, 2025
@jackw jackw force-pushed the jackw/plugin-e2e-node-24 branch from bf0f2be to d458ccb Compare October 28, 2025 09:47
@github-actions
Copy link
Contributor

Playwright test results

Image Name Version Result Report
grafana-dev 12.3.0-18866528426 ✅
grafana-enterprise 12.2.1 ✅
grafana-enterprise 11.5.10 ✅
grafana-enterprise 10.3.12 ✅
grafana-enterprise 9.3.16 ✅
grafana-enterprise 8.5.27 ✅
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

@jackw jackw merged commit 4a035dd into main Oct 28, 2025
34 checks passed
@jackw jackw deleted the jackw/plugin-e2e-node-24 branch October 28, 2025 10:50
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Oct 28, 2025
@grafana-plugins-platform-bot
Copy link
Contributor

🚀 PR was released in @grafana/[email protected], [email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@academo academo academo approved these changes

@hugohaggmark hugohaggmark hugohaggmark approved these changes

@sunker sunker sunker approved these changes

@toddtreece toddtreece Awaiting requested review from toddtreece toddtreece is a code owner automatically assigned from grafana/plugins-platform-backend

@briangann briangann Awaiting requested review from briangann briangann is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees

@jackw jackw

Labels

major Increment the major version when merged plugin-e2e related to the plugin-e2e package release Create a release when this pr is merged released This issue/pull request has been released.

Projects

Plugins Platform / Grafana Community
Status: 🚀 Shipped

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: Support Node 24

4 participants

@jackw @academo @hugohaggmark @sunker